[instrumentation/wsgi] fix NonRecordingSpan bug #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
approved these changes
Mar 10, 2022
lzchen
approved these changes
Mar 10, 2022
added 5 commits
March 10, 2022 09:31
There was a bug caused by accessing `.kind` on a NonRecordingSpan. Added a test to validate the fix. Fix open-telemetry#956
codeboten
force-pushed
the
codeboten/fix-non-recording-bug
branch
from
f011948 to
8ef96f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug caused by accessing
.kindon a NonRecordingSpan. Added a test to validate the fix.Fix #956