Added asgiref depedency to opentelemetry-instrumentation-asgi #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
fix-asgi-instrumentation
branch
2 times, most recently
from
7feca9a to
6ea107e
Compare
opentelemetry-instrumentaiton-asgi does not contain an instrumentor for asgiref. Instead, it implements an ASGI middleware that other instrumentors import and use. As such, other instrumentors can take a dependency on this package without asgiref being installed locally. This commit adds `asgiref` as a dependency to the opentelemetry-instrumentation-asgi package so the middleware can function properly when used by another instrumentation.
owais
force-pushed
the
fix-asgi-instrumentation
branch
from
6ea107e to
3b5ca07
Compare
oxeye-nikolay
approved these changes
Oct 20, 2021
lzchen
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opentelemetry-instrumentaiton-asgi does not contain an instrumentor for
asgiref. Instead, it implements an ASGI middleware that other
instrumentors import and use. As such, other instrumentors can take a
dependency on this package without asgiref being installed locally. This
commit adds
asgirefas a dependency to theopentelemetry-instrumentation-asgi package so the middleware can
function properly when used by another instrumentation.
Fixes #764
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.