Skip to content

disable elasticcachesearch7 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

disable elasticcachesearch7 #619

merged 1 commit into from
Aug 12, 2021

Conversation

@codeboten
Copy link
Contributor

@codeboten codeboten commented Aug 12, 2021

this tox task appears to be hanging. This is what I saw when I ran it locally:


test_elasticsearch.py::TestElasticsearchIntegration::test_dsl_create FAILED                                                                        [  8%]
test_elasticsearch.py::TestElasticsearchIntegration::test_dsl_index FAILED                                                                         [ 16%]
test_elasticsearch.py::TestElasticsearchIntegration::test_dsl_search FAILED                                                                        [ 25%]
test_elasticsearch.py::TestElasticsearchIntegration::test_instrumentor FAILED                                                                      [ 33%]
test_elasticsearch.py::TestElasticsearchIntegration::test_multithread

@codeboten codeboten requested review from a team, owais and srikanthccv and removed request for a team August 12, 2021 16:32
@codeboten
Copy link
Contributor Author

codeboten commented Aug 12, 2021

Issue to decide what to do w/ elastic7: #620

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 12, 2021
@codeboten codeboten mentioned this pull request Aug 12, 2021
Closed
NathanielRN
NathanielRN approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added a comment to add a comment about the issue?

tox.ini
elasticsearch6: elasticsearch>=6.0,<7.0
elasticsearch7: elasticsearch-dsl>=7.0,<8.0
elasticsearch7: elasticsearch>=7.0,<8.0
; elasticsearch7: elasticsearch-dsl>=7.0,<8.0
Copy link
Contributor

@NathanielRN NathanielRN Aug 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
; elasticsearch7: elasticsearch-dsl>=7.0,<8.0
; FIXME: Elasticsearch >=7 causes CI workflow tests to hang, see open-telemetry/opentelemetry-python-contrib#620
; elasticsearch7: elasticsearch-dsl>=7.0,<8.0

@lzchen lzchen merged commit d14d888 into main Aug 12, 2021
@codeboten codeboten mentioned this pull request Aug 12, 2021
Merged
@codeboten codeboten deleted the codeboten/disable-elastic7 branch August 12, 2021 20:06
@ocelotl ocelotl mentioned this pull request Aug 13, 2021
Closed
@ocelotl ocelotl mentioned this pull request Aug 24, 2021
Closed
@srikanthccv srikanthccv mentioned this pull request Feb 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owais owais owais approved these changes

@aabmass aabmass aabmass approved these changes

+2 more reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@NathanielRN NathanielRN NathanielRN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@codeboten @owais @aabmass @srikanthccv @NathanielRN @lzchen