-
Notifications
You must be signed in to change notification settings - Fork 806
Add missing license and manifests to the instrumentation packages. #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing license and manifests to the instrumentation packages. #616
Conversation
|
|
Thanks for the PR ✌️ Please sign the CLA 🙂 |
NathanielRN
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Added a comment about the CHANGELOG.md file but otherwise looks great 🙂
| global-exclude *.pyc | ||
| global-exclude *.pyo | ||
| global-exclude __pycache__/* | ||
| include CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line? I don't see it in this package. Same for all the other MANIFEST.in files?
| global-exclude *.pyc | ||
| global-exclude *.pyo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what kind of files have these extensions 😅 But looks like we do it everywhere so can't be too much harm to have this?
codeboten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mariusvniekerk, please sign the CLA so we can get this merged.
|
@mariusvniekerk Thanks for the contribution. This is ready to go but we need you to sign the CLA before we can merge :) Check this comment for details on how to sign: #616 (comment) |
|
Last ping before we decide to close/take over this PR. Please fix the build so we can merge this in. |
|
@mariusvniekerk |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.