Skip to content

Conversation

@mariusvniekerk
Copy link

@mariusvniekerk mariusvniekerk commented Aug 11, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@mariusvniekerk mariusvniekerk requested review from a team, NathanielRN and owais and removed request for a team August 11, 2021 13:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 11, 2021

CLA Not Signed

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 11, 2021
@ocelotl
Copy link
Contributor

ocelotl commented Aug 11, 2021

Thanks for the PR ✌️

Please sign the CLA 🙂

Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Added a comment about the CHANGELOG.md file but otherwise looks great 🙂

global-exclude *.pyc
global-exclude *.pyo
global-exclude __pycache__/*
include CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line? I don't see it in this package. Same for all the other MANIFEST.in files?

Comment on lines +3 to +4
global-exclude *.pyc
global-exclude *.pyo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what kind of files have these extensions 😅 But looks like we do it everywhere so can't be too much harm to have this?

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mariusvniekerk, please sign the CLA so we can get this merged.

@owais
Copy link
Contributor

owais commented Aug 24, 2021

@mariusvniekerk Thanks for the contribution. This is ready to go but we need you to sign the CLA before we can merge :)

Check this comment for details on how to sign: #616 (comment)

@ocelotl
Copy link
Contributor

ocelotl commented Sep 28, 2021

@owais, @lzchen this is a good contribution that has been sitting here for a while now. Would you be ok with merging it even without a CLA?

@ocelotl
Copy link
Contributor

ocelotl commented Sep 29, 2021

@owais, @lzchen this is a good contribution that has been sitting here for a while now. Would you be ok with merging it even without a CLA?

We have decided not to merge without a CLA.

@lzchen
Copy link
Contributor

lzchen commented Sep 29, 2021

@mariusvniekerk

Last ping before we decide to close/take over this PR. Please fix the build so we can merge this in.

@lzchen
Copy link
Contributor

lzchen commented Feb 2, 2022

@mariusvniekerk
Closing this PR for now. Feel free to comment/open it back up if you resume work on it.

@lzchen lzchen closed this Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants