Skip to content

Conversation

@tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Aug 28, 2025

Description

The order of headers and sections for 8 instrumentors' ReadTheDocs content is messed up, so I'm fixing them.

The contents of the sections themselves have not changed (text, code examples); I only moved them around.

Before this change, Django docs:

messy_headers

With this change, 3 sections with subheaders:

proper_sections

Partially fixes #3162

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. Virtualenv in Python 3.11
  2. tox -e docs
  3. Check local build in docs/_build/html/instrumentation/*/*.html

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review August 28, 2025 22:18
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner August 28, 2025 22:18
@xrmx xrmx moved this to Easy to review / merge / close in @xrmx's Python PR digest Aug 29, 2025
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@aabmass aabmass merged commit fd21563 into open-telemetry:main Aug 29, 2025
632 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in @xrmx's Python PR digest Aug 29, 2025
@tammy-baylis-swi tammy-baylis-swi deleted the sqlcomment-docs branch August 29, 2025 21:16
zhirafovod pushed a commit to zhirafovod/opentelemetry-python-contrib that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve documentation of instrumentation's sqlcommenter feature

5 participants