system-metrics: Add cpython.gc.collections metric
#3617
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Jul 14, 2025
| @@ -469,6 +470,12 @@ def _instrument(self, **kwargs: Any): | |||
| description=f"Runtime {self._python_implementation} GC count", | |||
| unit="By", | |||
| ) | |||
| self._meter.create_observable_counter( | |||
| name=f"process.runtime.{self._python_implementation}.gc_count", | |||
There was a problem hiding this comment.
I think the name should be cpython.gc.collections no?
There was a problem hiding this comment.
thanks for the catch. added this metrics name. this also aligns to your other comment. Now it gets its own if
emdneto
reviewed
Jul 14, 2025
| @@ -469,6 +470,12 @@ def _instrument(self, **kwargs: Any): | |||
| description=f"Runtime {self._python_implementation} GC count", | |||
| unit="By", | |||
| ) | |||
| self._meter.create_observable_counter( | |||
There was a problem hiding this comment.
Since it doesn't work with pypy, can we skip for pypy from here?
|
Short question: Should we comment that the old metric is deprecated ? |
david-gang
force-pushed
the
gc_count_collection_unit
branch
from
d4d91eb to
4003bb0
Compare
|
@emdneto may you please take another look on the PR and see that all your comments were addressed? |
emdneto
approved these changes
Jul 23, 2025
CHANGELOG.md
Outdated
| - `opentelemetry-instrumentation-asgi`: fix excluded_urls in instrumentation-asgi | ||
| ([#3567](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3567)) | ||
| - `opentelemetry-resource-detector-containerid`: make it more quiet on platforms without cgroups | ||
| ([#3579](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3579)) | ||
| - `opentelemetry-instrumentation-system-metrics`: Add cpython.gc.collections metrics with collection unit is specified in semconv ([3617](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3617)) |
There was a problem hiding this comment.
Suggested change
| - `opentelemetry-instrumentation-system-metrics`: Add cpython.gc.collections metrics with collection unit is specified in semconv ([3617](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3617)) | |
| - `opentelemetry-instrumentation-system-metrics`: Add `cpython.gc.collections` metric with collection unit specified in semconv ([#3617](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3617)) |
There was a problem hiding this comment.
can u move to the Unreleased section?
emdneto
changed the title
cpython.gc.collections metric
david-gang
force-pushed
the
gc_count_collection_unit
branch
from
4003bb0 to
298a072
Compare
david-gang
force-pushed
the
gc_count_collection_unit
branch
from
298a072 to
8a51981
Compare
|
@emdneto The failing test is connected to this PR. Interesting why this happens. It fails in the sqlalchemy tests which was not touched here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3549
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The change is trivial as
opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-system-metrics/tests/test_system_metrics.py
Line 952 in b74633a
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
I try to keep this pr as small as possible. After this is merged i want to add the cpython.gc.collected_objects and cpython.gc.uncollectable_objects metrics from https://github.com/open-telemetry/semantic-conventions/blob/2bc97890c1ad82232745b4dd74fd3144476b6a5c/docs/runtime/cpython-metrics.md#metric-cpythongccollected_objects