refactor (boto3sqs) spans #3542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
got rid of MESSAGING_DESTINATION_KIND (deprecated) |
...pentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py
Show resolved
Hide resolved
Comment on lines
+53
to
+55
| from opentelemetry.semconv._incubating.attributes.server_attributes import ( | ||
| SERVER_ADDRESS, | ||
| ) |
There was a problem hiding this comment.
Instead of the _incubating SERVER_ADDRESS (deprecated), let's use the stable version.
xrmx
reviewed
May 27, 2025
| from opentelemetry.semconv.trace import ( | ||
| MessagingDestinationKindValues, | ||
| MessagingOperationValues, |
There was a problem hiding this comment.
This is MessagingOperationTypeValues
There was a problem hiding this comment.
Thank you for the clarification. Is there a way to find which attribute correlates to which? The naming conventions for these sometimes do not match up such as the instance above.
There was a problem hiding this comment.
@weslayer You can check the actual string values of these constants, they usually match the expected attribute values, even if the naming conventions differ.
There was a problem hiding this comment.
Thank you, that is a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Refs #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.