Skip to content

Stop using SpanAttributes #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
10 of 41 tasks
xrmx opened this issue May 7, 2025 · 12 comments
Open
10 of 41 tasks

Stop using SpanAttributes #3475

xrmx opened this issue May 7, 2025 · 12 comments
Labels
good first issue Good for newcomers

Comments

@xrmx
Copy link
Contributor

xrmx commented May 7, 2025 •
edited
Loading

A lot of code imports semantic conventions attributes from opentelemetry.semconv.trace.SpanAttributes instead of the preferred opentelemetry.semconv.attributes and opentelemetry.semconv.incubating.

Here's the list of of packages found grepping SpanAttributes on a recent checkout. Some packages may be more easy than others to convert since there may just be a couple of instances to fix.

People willing to help with this, state in the issue on what package you are going to work and you have 1 week to create a PR, after that we'll consider the package available to others.

The PR message should contains Refs #3475 instead of Fixes #3475.

Updated of instrumentation specific tests in tests/opentelemetry-docker-tests should probably go on par with the conversion of the instrumentation package.
@xrmx xrmx added the good first issue Good for newcomers label May 7, 2025
@zhengkezhou1
Copy link

@xrmx i would like to start with instrumentation/opentelemetry-instrumentation-confluent-kafka as my first PR.

@TheShubhendra
Copy link
Contributor

I would like to work on instrumentation/opentelemetry-instrumentation-fastapi

TheShubhendra added a commit to TheShubhendra/opentelemetry-python-contrib that referenced this issue May 10, 2025
@TheShubhendra
refactor(fastapi): migrate HTTP_ROUTE from SpanAttributes to new sema…
b088bcb 
…ntic conventions

Replaced usage of `SpanAttributes.HTTP_ROUTE` with `opentelemetry.semconv.attributes.http_attributes.HTTP_ROUTE`
as part of the migration away from `SpanAttributes`.

Refs: open-telemetry#3475
@TheShubhendra TheShubhendra mentioned this issue May 10, 2025
Merged
11 tasks
@zhengkezhou1 zhengkezhou1 mentioned this issue May 10, 2025
Open
5 tasks
@IAmPrajna
Copy link
Contributor

I am working on instrumentation/opentelemetry-instrumentation-requests

@IAmPrajna IAmPrajna mentioned this issue May 11, 2025
Merged
11 tasks
@almudenasanz
Copy link
Contributor

I am working on exporter/opentelemetry-exporter-richconsole

@almudenasanz almudenasanz mentioned this issue May 15, 2025
Merged
11 tasks
@caterinaandreu caterinaandreu mentioned this issue May 15, 2025
Merged
11 tasks
@almudenasanz almudenasanz mentioned this issue May 15, 2025
Merged
11 tasks
@almudenasanz
Copy link
Contributor

I am working on instrumentation/opentelemetry-instrumentation-elasticsearch ↑

@caterinaandreu
Copy link
Contributor

I am working on:

  • instrumentation/opentelemetry-instrumentation-aiohttp-client
  • instrumentation/opentelemetry-instrumentation-aiohttp-server

@caterinaandreu caterinaandreu mentioned this issue May 15, 2025
Merged
11 tasks
@tdancheva tdancheva mentioned this issue May 15, 2025
Merged
11 tasks
xrmx added a commit that referenced this issue May 19, 2025
@TheShubhendra @xrmx
refactor(fastapi): replace uses of SpanAttributes with `opentelemet…
ec73158 
…ry.semconv.attributes` (#3491)

* refactor(fastapi): migrate HTTP_ROUTE from SpanAttributes to new semantic conventions

Replaced usage of `SpanAttributes.HTTP_ROUTE` with `opentelemetry.semconv.attributes.http_attributes.HTTP_ROUTE`
as part of the migration away from `SpanAttributes`.

Refs: #3475

* refactor(fastapi): refactor tests

* refactor(fastapi): remove duplicated import

* sort imports

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
This was referenced May 22, 2025
Merged
Merged
Merged
@weslayer
Copy link
Contributor

I would like to work on instrumentation/opentelemetry-instrumentation-boto

@weslayer weslayer mentioned this issue May 23, 2025
Merged
11 tasks
@artemziborev
Copy link

Hi! I'd like to work on
instrumentation/opentelemetry-instrumentation-flask
nstrumentation/opentelemetry-instrumentation-grpc
I'll create a PR within a week.

This was referenced May 23, 2025
Open
Open
@weslayer
Copy link
Contributor

Hello, I will also be working on the following:
instrumentation/opentelemetry-instrumentation-aws-lambda
instrumentation/opentelemetry-instrumentation-boto3sqs
instrumentation/opentelemetry-instrumentation-botocore

@xrmx
Copy link
Contributor Author

xrmx commented May 24, 2025

Hello, I will also be working on the following: instrumentation/opentelemetry-instrumentation-aws-lambda instrumentation/opentelemetry-instrumentation-boto3sqs instrumentation/opentelemetry-instrumentation-botocore

Please open one PR at a time

This was referenced May 25, 2025
Merged
Open
@xrmx
Copy link
Contributor Author

xrmx commented May 27, 2025 •
edited
Loading

@weslayer @artemziborev The PR message should contains Refs #3475 instead of Fixes #3475 otherwise you'll close this issue. Already fixed your PRs but keep it in mind if you are gonna open more PRs.

@andyvu923
Copy link
Contributor

I would like to work on instrumentation/opentelemetry-instrumentation-wsgi

@andyvu923 andyvu923 mentioned this issue May 28, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@xrmx @almudenasanz @caterinaandreu @zhengkezhou1 @TheShubhendra @artemziborev @weslayer @IAmPrajna @andyvu923