Skip to content

resource-dector-container: package rename to opentelemetry-resource-detector-containerid #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented May 22, 2025

Description

Fix #3455
Close #1923

I tested the ./scripts/build.sh and everything is fine, so I expect no problems with the release @open-telemetry/python-maintainers

@emdneto emdneto requested a review from a team as a code owner May 22, 2025 19:26

def test_container_id_entrypoint(self):
(entrypoint,) = entry_points(
group="opentelemetry_resource_detector", name="container"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change entrypoint name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya that would be good

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge #3429 before renaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: rename package opentelemetry-resource-detector-container ContainerResourceDetector is not available via pip install
3 participants