Proposal: rename package opentelemetry-resource-detector-container

[emdneto]

Description

Per issue #1923 and also pypi/support#3374, which has no estimated time of resolution, I propose to SIG that we vote to rename the contrib package opentelemetry-resource-detector-container so we can release it in the regular monthly releases.

Some options for renaming it:

• opentelemetry-resource-detector-cgroup
• opentelemetry-resource-detector-container-metadata
• opentelemetry-resource-detector-containerid
• opentelemetry-resource-detector-oci (OCI from Open Container Initiative) - @aabmass suggestion discarded

Suggestions are welcome.

[emdneto]

I'm more inclined to one of:

• opentelemetry-resource-detector-cgroup
• opentelemetry-resource-detector-oci discarded

[aabmass]

After doing a little digging, I don't think -oci is a good choice since it's not part of the spec opencontainers/runtime-spec#1105. It seems to be a docker convention which probably works on other container runtimes.

[aabmass]

Right now, it only detects the container ID:

opentelemetry-python-contrib/resource/opentelemetry-resource-detector-container/src/opentelemetry/resource/detector/container/__init__.py

Lines 81 to 83 in da661f6

	resource = resource.merge(
	Resource({ResourceAttributes.CONTAINER_ID: container_id})
	)

Do you think we will expand this to other attributes? If not, maybe opentelemetry-resource-detector-container(?-)id

[emdneto]

Right now, it only detects the container ID:

opentelemetry-python-contrib/resource/opentelemetry-resource-detector-container/src/opentelemetry/resource/detector/container/init.py

Lines 81 to 83 in da661f6

resource = resource.merge(
Resource({ResourceAttributes.CONTAINER_ID: container_id})
)
Do you think we will expand this to other attributes? If not, maybe opentelemetry-resource-detector-container(?-)id

At this moment, I don't see a way we can collect other metadata from inside the container itself. Other attributes like image depend on the access to the runtime, which in most scenarios isn't suitable inside the container. That said, I think opentelemetry-resource-detector-container-metadata or your suggestion with id makes more sense.

[emdneto]

My vote: opentelemetry-resource-detector-containerid, without the hyphen.