Skip to content

Refactor: replace use of SpanAttributes in test-instrumentation-aiohttp-server #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Refactor: replace use of SpanAttributes in test-instrumentation-aiohttp-server #3504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...ion/opentelemetry-instrumentation-aiohttp-server/tests/test_aiohttp_server_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@
AioHttpServerInstrumentor,
)
from opentelemetry.instrumentation.utils import suppress_http_instrumentation
from opentelemetry.semconv.trace import SpanAttributes
from opentelemetry.semconv._incubating.attributes.http_attributes import (
HTTP_METHOD,
HTTP_STATUS_CODE,
HTTP_URL,
)
from opentelemetry.test.globals_test import reset_trace_globals
from opentelemetry.test.test_base import TestBase
from opentelemetry.util._importlib_metadata import entry_points
Expand Down Expand Up @@ -127,15 +131,11 @@ async def test_status_code_instrumentation(

[span] = memory_exporter.get_finished_spans()

assert expected_method.value == span.attributes[SpanAttributes.HTTP_METHOD]
assert (
expected_status_code
== span.attributes[SpanAttributes.HTTP_STATUS_CODE]
)
assert expected_method.value == span.attributes[HTTP_METHOD]
assert expected_status_code == span.attributes[HTTP_STATUS_CODE]

assert (
f"http://{server.host}:{server.port}{url}"
== span.attributes[SpanAttributes.HTTP_URL]
f"http://{server.host}:{server.port}{url}" == span.attributes[HTTP_URL]
)


Expand Down
Loading