Skip to content

make urllib test less flaky #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2025
Merged

make urllib test less flaky #3336

merged 4 commits into from
Mar 5, 2025

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Mar 5, 2025 •
edited
Loading

@github-actions github-actions bot requested a review from shalevr March 5, 2025 17:28
@emdneto
ruff
9d52e4b 
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 5, 2025
shalevr
shalevr approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@shalevr shalevr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@aabmass aabmass enabled auto-merge (squash) March 5, 2025 21:13
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@aabmass
Copy link
Member

aabmass commented Mar 5, 2025

@emdneto not sure why it doesn't think I signed the CLA. Would you mind pushing an empty commit or force pushing without ff1a31f?

@emdneto emdneto force-pushed the urllib-flaky-test branch from ff1a31f to 9d52e4b Compare March 5, 2025 21:25
@emdneto
Copy link
Member Author

emdneto commented Mar 5, 2025 •
edited
Loading

@emdneto not sure why it doesn't think I signed the CLA. Would you mind pushing an empty commit or force pushing without ff1a31f?

That was weird. Done

@aabmass aabmass merged commit a83c8d9 into open-telemetry:main Mar 5, 2025
712 checks passed
@xrmx xrmx mentioned this pull request Mar 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@shalevr shalevr shalevr approved these changes

Assignees

@shalevr shalevr

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emdneto @aabmass @shalevr