bug_fix(1477): type handling in _add_sql_comment #3113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xrmx
requested changes
Dec 23, 2024
Kludex
reviewed
Jan 10, 2025
opentelemetry-instrumentation/src/opentelemetry/instrumentation/sqlcommenter_utils.py
Outdated
Show resolved
Hide resolved
aryabharat
force-pushed
the
fix/1477
branch
2 times, most recently
from
5cb5d9d to
577f808
Compare
github-actions
bot
assigned
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen,
nemoshlag and
nirga
aryabharat
force-pushed
the
fix/1477
branch
3 times, most recently
from
5e98fce to
cc7332d
Compare
|
@tammy-baylis-swi Please let me what all changes are required. |
tammy-baylis-swi
approved these changes
Feb 25, 2025
tammy-baylis-swi
moved this from Easy to review / merge / close
to Approved PRs
in @xrmx's Python PR digest
xrmx
approved these changes
Feb 27, 2025
|
@Kludex Please can you review? |
|
@xrmx @tammy-baylis-swi can we merge this? |
|
Hi @Kludex can we merge this? |
Kludex
reviewed
Mar 19, 2025
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Show resolved
Hide resolved
|
Please stop pinging me. I do not have bandwidth to review this again. I've shared my concerns already. |
I have replied to your comment. |
|
@xrmx Please have a look, if this is not accepted then we can close this PR. |
|
@aryabharat Please stop pinging people, this will be merged eventually. |
emdneto
approved these changes
Mar 26, 2025
lzchen
approved these changes
Mar 26, 2025
github-project-automation
bot
moved this from Approved PRs
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with SQL comment generation, the current implementation fails when processing non-string SQL queries, particularly those from psycopg2's SQL utilities.
Modified _add_sql_comment() function to handles different SQL query types by converting incoming sql queries to strings
Preserves the original query if comment generation fails
Fixes #1477
Type of change
Please delete options that are not relevant.