Add type hints to psycopg
#3067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it a docstring error? |
Kludex
commented
Dec 12, 2024
.../opentelemetry-instrumentation-psycopg/src/opentelemetry/instrumentation/psycopg/__init__.py
Show resolved
Hide resolved
|
Anything I can do to speed up the review process here? @xrmx |
aabmass
reviewed
Jan 13, 2025
...rumentation/opentelemetry-instrumentation-psycopg/src/opentelemetry/instrumentation/py.typed
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Jan 14, 2025
aabmass
approved these changes
Jan 15, 2025
xrmx
added a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
* Add type hints to Psycopg * fix tests * fix * Add psycopg.Connection to nitpick * Add py.typed * add psycopg to nitpick again * add psycopg to nitpick again * move py.typed to the right folder --------- Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentelemetry-instrumentation-psycopgclaims to work for async queries, but doesn't record time #2486.