Skip to content

Upgrade Werkzeug library for testing #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Upgrade Werkzeug library for testing #2623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ce3800
Upgrade Werkzeug library for testing
rbagd Jun 19, 2024
7e4cb9b
Merge branch 'main' into upgrade-werkzeug
lzchen Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instrumentation/opentelemetry-instrumentation-pyramid/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ translationstring==1.4
typing_extensions==4.9.0
venusian==3.1.0
WebOb==1.8.7
Werkzeug==0.16.1
Werkzeug==3.0.3
wrapt==1.16.0
zipp==3.17.0
zope.deprecation==5.0
Expand Down
9 changes: 2 additions & 7 deletions instrumentation/opentelemetry-instrumentation-pyramid/tests/pyramid_base_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@

import pyramid.httpexceptions as exc
from pyramid.response import Response
from werkzeug.test import Client

# opentelemetry-instrumentation-pyramid uses werkzeug==0.16.1 which has
# werkzeug.wrappers.BaseResponse. This is not the case for newer versions of
# werkzeug like the one lint uses.
from werkzeug.wrappers import BaseResponse # pylint: disable=no-name-in-module
from werkzeug.test import Client, TestResponse


class InstrumentationTest:
Expand Down Expand Up @@ -77,4 +72,4 @@ def excluded2_endpoint(request):
)

# pylint: disable=attribute-defined-outside-init
self.client = Client(config.make_wsgi_app(), BaseResponse)
self.client = Client(config.make_wsgi_app(), TestResponse)