fix(grpc): aio grpc client interceptor incorrect metadata handling #2363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug when using grpcio>=1.60.0 and the gRPC telemetry. Introduced by grpc/grpc#34347 a tuple metadata is always converted to a
Metadataobject which follows the Python grpc docs and typing. In the current opentelemetry implementation there is a conversion to anOrderedDictwhich causes :This PR makes use of the
Metadataobject directly and propagates it as such.This could cause regressions for some following interceptors handling metadata as tuples (same way this regression happened), I'm not sure if this would qualify as a breaking change though.
Type of change
How Has This Been Tested?
Added metadata in grpc tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.