Skip to content

Conversation

@johnbley
Copy link
Member

Description

Run shellcheck --severity=warning and fix all issues - some from main repo, a dead variable, a safety check to make sure rm -rf doesn't erase the file system, etc.

If desired, I could add a PR for enabling a shellcheck CI step similar to open-telemetry/opentelemetry-lambda#396

Does This PR Require a Core Repo Change?

Some scripts from the core repo also changed, linking both directions for completeness:

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 19, 2024
@lzchen
Copy link
Contributor

lzchen commented Mar 19, 2024

Test is failing from an unrelated change. Wait unitl this is merged.

@lzchen
Copy link
Contributor

lzchen commented Apr 2, 2024

@johnbley

If desired, I could add a PR for enabling a shellcheck CI step similar to open-telemetry/opentelemetry-lambda#396

I think this would be a great thing to have. Feel free to include that as part of this pr.

@johnbley
Copy link
Member Author

johnbley commented Apr 3, 2024

I think [shellcheck CI step] would be a great thing to have. Feel free to include that as part of this pr.

👍

@lzchen lzchen enabled auto-merge (squash) April 16, 2024 16:15
auto-merge was automatically disabled April 16, 2024 16:20

Pull Request is not mergeable

@lzchen lzchen merged commit 8322ee7 into open-telemetry:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants