Skip to content

Conversation

@liustanley
Copy link
Contributor

@liustanley liustanley commented Mar 30, 2023

Description

This PR adds the process. prefix to the following runtime metrics:

  • runtime.memory
  • runtime.cpu.time
  • runtime.gc_count

This PR also changes runtime.memory to be an UpDownCounter instead of a count, since the semantic conventions list process.memory.usage as an UpDownCounter.

Fixes #1722

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@liustanley liustanley requested a review from a team March 30, 2023 14:45
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@liustanley liustanley requested a review from srikanthccv April 3, 2023 14:50
@srikanthccv srikanthccv merged commit e4d42e6 into open-telemetry:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime metrics don't follow semantic conventions

2 participants