Strip leading comments from SQL queries when generating the span name. #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogersd
force-pushed
the
drogers-strip-comments
branch
2 times, most recently
from
ffc972a to
aab3faa
Compare
|
We also have similar logic in a few other places and need to update them too. If you don't want to address it in this PR, Please update the description from Fixes #XX -> Part of #XX. |
rogersd
force-pushed
the
drogers-strip-comments
branch
from
aab3faa to
44c9bb3
Compare
|
I updated it in |
rogersd
force-pushed
the
drogers-strip-comments
branch
5 times, most recently
from
e1c090f to
a663628
Compare
rogersd
force-pushed
the
drogers-strip-comments
branch
from
a663628 to
7757e45
Compare
srikanthccv
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently an SQL statement that begins with a comment, such as
Will have
span.nameset to/*, which makes it harder to tell what's going on in the waterfall view for a request.Instead, this removes the leading comment so that the operation type is used instead.
Fixes #1433
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: