Skip to content

Conversation

@rogersd
Copy link
Contributor

@rogersd rogersd commented Oct 27, 2022

Next part of #1184

Description

Add test cases for regular expression matching.
Add test cases for header sanitizing.
Add documentation for regular expression matching and header sanitation.
Various documentation cleanups and standardization.

Fixes #1184

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests added.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rogersd rogersd requested a review from a team October 27, 2022 16:50

pip install opentelemetry-instrumentation-flask

Configuration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup got missed in ae7a415

@srikanthccv srikanthccv enabled auto-merge (squash) October 29, 2022 07:40
@srikanthccv srikanthccv merged commit 26d3343 into open-telemetry:main Oct 29, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more features for adding HTTP request / response headers to spans.

2 participants