Skip to content

Conversation

@rahuldimri
Copy link
Contributor

@rahuldimri rahuldimri commented Aug 8, 2022

Description

Manifest.ini file missing for the location from the below location.

opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-aio-pika/

Fixes # 1221

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rahuldimri rahuldimri requested a review from a team August 8, 2022 12:22
@rahuldimri rahuldimri changed the title Creating MANIFEST.in Creating MANIFEST.in #1221 Aug 8, 2022
@srikanthccv
Copy link
Member

You can add all missing files in just one PR as a part of #893.

@rahuldimri
Copy link
Contributor Author

@srikanthccv thank for the suggestion. As we 3 are working on this issue. We wanted to have this submitted from our own id.

If you still think this is not the correct way, We will open another PR for the same.

@srikanthccv
Copy link
Member

I don't think this is such an issue that requires multiple PRs from multiple people. This is a trivial change that doesn't touch actual code. Please just create one PR with all the missing files.

@srikanthccv
Copy link
Member

#1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants