Logging instr hook #1117
Merged
Logging instr hook #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxeye-nikolay
approved these changes
Jun 9, 2022
srikanthccv
reviewed
Jun 9, 2022
Co-authored-by: Srikanth Chekuri <[email protected]>
|
@nozik Should I keep you as co-author? I would encourage just one person to add commits on top unless the original author can't work on this PR anymore. |
|
@srikanthccv You can keep @nata7che as the only author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a hook to the log instrumentation. This enables multiple things such as adding data to log records.
Type of change
How Has This Been Tested?
Added a hook to the instrumentation and added an attribute to the record in it. made sure the added attribute exists on the record after instrumentation.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.