opentelemetry-instrumentation-threading version 0.51b0 prevents mypy from running on projects.

[tjordahl]

Describe your environment

OS: MacOS
Python version: Python 3.10.15
Package version: 0.51b0

What happened?

Running mypy on my project result in the following error:
venv/lib/python3.10/site-packages/opentelemetry/instrumentation/threading/__init__.py:132: error: Ellipses cannot accompany other argument types in function type signature [syntax]
Found 1 error in 1 file (errors prevented further checking)

Steps to Reproduce

Run mypy on the file init.py in instrumentation/opentelemetry-instrumentation-threading/src/opentelemetry/instrumentation/threading/__init__.py.

Expected Result

Expect mypy to run successfully.

Actual Result

venv/lib/python3.10/site-packages/opentelemetry/instrumentation/threading/__init__.py:132: error: Ellipses cannot accompany other argument types in function type signature [syntax]
Found 1 error in 1 file (errors prevented further checking)

Additional context

No response

Would you like to implement a fix?

No

[Kludex]

Application developers aren't supposed to run type checker on dependencies.

This is not a bug. This package is type checked with pyright.

---

That said, it's not a big effort to make mypy happy as well.

[tjordahl]

Agreed that mypy should keep its nose out of site-package (and in fact its documentation says it does) but the auto-updating of dependent libraries that pdm/pyproject.toml does stopped my entire team cold until we could track down what changed. The wonders of Continous Integration quality gates.

If you could fix this I would appreacate it. I will see if I can figure out why mypy is even looking at it - it has something to do with follow-imports I believe, but turning that off was a no-go.

[yulin-li]

same issue here, seems mypy regards this as a syntax error and stops doing further check, see python/mypy#6897

So, basically all projects importing opentelemetry.instrumentation.threading cannot pass mypy check now.

[Kludex]

I see... So even if you use # type: ignore, it fails...

from opentelemetry.instrumentation.threading import ThreadingInstrumentor  # type: ignore

ThreadingInstrumentor().instrument()

I'll open a PR. But IMO this is something mypy should work on... As a user I can't ignore this error without setting the follow-imports to False.

[tjordahl]

Its even worse than that as my project doesn't import this library directly another library I use does, which means I have no control over it.

Thanks very much for fixing this @Kludex !