-
Notifications
You must be signed in to change notification settings - Fork 941
feat(sdk-trace-base): add spanProcessors property in TracerConfig interface
#5138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-trace-base): add spanProcessors property in TracerConfig interface
#5138
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
==========================================
- Coverage 93.21% 93.17% -0.05%
==========================================
Files 315 314 -1
Lines 8096 8076 -20
Branches 1622 1622
==========================================
- Hits 7547 7525 -22
- Misses 549 551 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two nits, looks good overall (most of this has been reviewed at #5134 - so I mostly skimmed over it) 🙂
thanks for working on this 🙌
spanProcessors property in TracerConfig interfacespanProcessors property in TracerConfig interface
Which problem is this PR solving?
addSpanProcessorAPI is planned to be removed in the next major version. This PR adds thespanProcessorsconfig option in the tracer provider base class so users can migrate to this new way of configuring the tracer provider.Ref #4792
Short description of the changes
spanProcessorsproperty inTracerConfigBasicTraceProvidet.test.tsto test the new property@opentelemetry/sdk-nodeto use the new constructor APITracerProviderWithEnvExporterclass from@opentelemetry/sdk-node@opentelemetry/sdk-nodetestsType of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: