Skip to content

Conversation

@project0
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Adds a additional hook for aws sdk exceptions

@project0 project0 requested a review from a team August 22, 2024 13:16
@project0 project0 force-pushed the feat/aws-sdk-exception branch 3 times, most recently from dd9b3b3 to 117d248 Compare August 22, 2024 19:51
@david-luna
Copy link
Contributor

Ping to component owners
@jj22ee @blumamir

@project0 project0 force-pushed the feat/aws-sdk-exception branch from 117d248 to 8de2ca6 Compare November 26, 2024 09:42
@project0 project0 requested a review from a team as a code owner November 26, 2024 09:42
@project0 project0 force-pushed the feat/aws-sdk-exception branch from 8de2ca6 to 8fe1574 Compare December 5, 2024 16:32
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.84%. Comparing base (652dbf9) to head (3e7bd85).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/instrumentation-aws-sdk/src/aws-sdk.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2398   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         188      188           
  Lines        9272     9282   +10     
  Branches     1901     1903    +2     
=======================================
+ Hits         8330     8339    +9     
- Misses        942      943    +1     
Files with missing lines Coverage Δ
packages/instrumentation-aws-sdk/src/aws-sdk.ts 92.77% <90.00%> (-0.17%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@project0
Copy link
Contributor Author

@blumamir @jj22ee @trivikr any chance we can move forward? Its already a couple of months without any review...

@project0 project0 force-pushed the feat/aws-sdk-exception branch from 8fe1574 to 29b9dd2 Compare February 18, 2025 10:04
@dyladan
Copy link
Member

dyladan commented May 14, 2025

@jj22ee can you please take a look at this? I know it was opened before you were made a component owner but it's been sitting for quite a while.

@dyladan
Copy link
Member

dyladan commented May 14, 2025

I think this feature looks reasonable. The package already has similar hooks defined and it is well documented/tested. If it gets rebased I think we can move forward with it. @jj22ee please comment if you disagree otherwise this will get my 👍

@jj22ee
Copy link
Contributor

jj22ee commented May 15, 2025

Hey, sorry for not taking a look at this, thanks @dyladan for the ping.
This provides useful custom span configuration by user in the event of an exception, so this change looks good.

@project0 I suppose this solves #1765 indirectly for you because this allows you to update Span status or unrecord the Span exception via the new exceptionHook?

Copy link
Contributor

@jj22ee jj22ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit of cleanup. After you resolve the conflicts + merge/rebase with main I'll approve.

@dyladan
Copy link
Member

dyladan commented Jul 9, 2025

Please resolve the conflicts and we can get this merged

@project0 project0 force-pushed the feat/aws-sdk-exception branch 2 times, most recently from 8586074 to c9779e5 Compare July 30, 2025 07:54
@project0
Copy link
Contributor Author

@dyladan sorry for the late response, i rebased everything and addressed the small linting issues.

@project0 project0 force-pushed the feat/aws-sdk-exception branch from c9779e5 to 24bedb6 Compare July 31, 2025 07:23
@project0 project0 requested a review from pichlermarc August 1, 2025 08:16
@project0 project0 force-pushed the feat/aws-sdk-exception branch from 24bedb6 to 562f028 Compare August 1, 2025 08:16
@jj22ee jj22ee added the has:owner-approval Approved by Component Owner label Aug 4, 2025
@pichlermarc pichlermarc enabled auto-merge (squash) August 6, 2025 13:24
@pichlermarc pichlermarc merged commit bf302a5 into open-telemetry:main Aug 6, 2025
29 of 30 checks passed
@dyladan dyladan mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants