fix(instrumentation-fastify): add tav script #1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1710 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 139 139
Lines 7125 7125
Branches 1431 1431
=======================================
Hits 6538 6538
Misses 587 587 |
timswinkels
approved these changes
Oct 5, 2023
|
@open-telemetry/javascript-approvers friendly ping 🙂 |
dyladan
approved these changes
Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We currently don't test against
fastifyversions after4.18.0becausefasitifyhas changed their minimum supported typescript version, this PR adds atest-all-versionsscript to the@opentelemetry/instrumentation-fastifypackage.Short description of the changes
Adds TAV script to test against later versions of
fastify