Fix latest dep tests #15429
Merged
Fix latest dep tests #15429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Nov 22, 2025
| SERVER_PORT, | ||
| NETWORK_PEER_ADDRESS, | ||
| NETWORK_PEER_PORT)); | ||
| if (Boolean.getBoolean("testLatestDeps")) { |
Contributor
Author
There was a problem hiding this comment.
somehow missed this while fixing lettuce latest dep test failures
laurit
commented
Nov 22, 2025
|
|
||
| testImplementation("org.springframework.boot:spring-boot-starter-web:$springBootVersion") | ||
| testImplementation("org.springframework.boot:spring-boot-starter-test:$springBootVersion") { | ||
| testLibrary("org.springframework.boot:spring-boot-starter-web:$springBootVersion") |
Contributor
Author
There was a problem hiding this comment.
previously we weren't testing the latest version here
laurit
commented
Nov 22, 2025
|
|
||
| testImplementation("org.springframework.boot:spring-boot-starter-web:3.0.0") | ||
| testImplementation("org.springframework.boot:spring-boot-starter-test:3.0.0") | ||
| testLibrary("org.springframework.boot:spring-boot-starter-web:3.0.0") |
Contributor
Author
There was a problem hiding this comment.
previously we weren't testing the latest version here
jaydeluca
approved these changes
Nov 22, 2025
This was referenced Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit spring boot version to fix latest dep tests. It might be easier to work on actually fixing these when the build passes. Then it is easier to spot other new failures from unrelated library updates.
Related to #14906