Skip to content

Conversation

hjmjohnson
Copy link
Contributor

The check converts the usage of null pointer constants (eg. NULL, 0) to
use the new C++11 nullptr keyword.

SRCDIR=/Users/johnsonhj/src/jsoncpp #My local SRC
BLDDIR=/Users/johnsonhj/src/jsoncpp/cmake-build-debug/ #My local BLD

cd /Users/johnsonhj/src/jsoncpp/cmake-build-debug/
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-,modernize-use-nullptr -header-filter=. -fix

The check converts the usage of null pointer constants (eg. NULL, 0) to
use the new C++11 nullptr keyword.

SRCDIR=/Users/johnsonhj/src/jsoncpp #My local SRC
BLDDIR=/Users/johnsonhj/src/jsoncpp/cmake-build-debug/ #My local BLD

cd /Users/johnsonhj/src/jsoncpp/cmake-build-debug/
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-nullptr  -header-filter=.* -fix
@hjmjohnson
Copy link
Contributor Author

@ibc @bernhardHartleb @mnaberez @bmcdorman I am interested in using jsoncpp, but I am extremely concerned that there is not a clear process for reviewing pull requests in a timely manner.

Is there a separate mailing list/blog site/communication channel that should be used to have a conversation about code contributions?

I am willing to maintain and update the CMake build system (it is required for incorporating into many of the National Alliance for Medical Image Computing software tools).

Best regards,
Hans

@cdunn2001
Copy link
Contributor

I am interested in using jsoncpp, but I am extremely concerned that there is not a clear process for reviewing pull requests in a timely manner.

I've been busy. But if you're sure you will maintain backward-compatibility, I will simply add you to the project so you can merge anything urgent.

@cdunn2001 cdunn2001 merged commit 9026a16 into open-source-parsers:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants