Svelvet v10.0 Pull Request #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
> > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
-Added svelvet-file-tree and scirpt.txt to gitignore -Titled README to reflect my branch -In Graph.svelte: Added comments to explain the file, added a Radio Group to the canvas for testing purposes. Note that the testing group does not work functionally. Found the 'quick save' feature started by previous devs, planning to define a function to save the canvas state as a JSON object in local storage -Added comments to +page.svelte to explain the file -Corrected typos in color-picker/test.ts comment Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
…ust the keyboard > > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
…ust the keyboard > > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
Mayson/canvaskeyboard func
Added type assertions in reloadStore.ts and saveStore.ts, getting rid of errors in functions. Added a test button to the +page.svelte svelvet wrapper to trigger the getJSONState function. Currently saves an empty object in local storage. Other comments added Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Solomon Moon <[email protected]> Co-authored-by: Julianb12 <[email protected]>
…oard shortcut 'd' to toggle drawer component > > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
…ts to the dev canvas > > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
- added dependencies to run ts -added interface, comments, test function to saveStore.ts/reloadStore.ts Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
… test. Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]>
> > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
- added a control flow to make sure transforms.scale property on Graph object exists as a number / reloadStore.ts - added a variable, graph, to subscribe to the graphStore and pass into getJSONState function / +page.svelte - added console logs to monitor graph state from mount to local storage Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
…ditor on a node using the 'e' key. > > Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
Toggle controls with 'c' key and render editor node with 'e' key Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Issac Bocage <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
Isaac feature branch
Mayson/keyboard functionality
Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Isaac Bocage [email protected]
Added ContrastTheme component Added a new component called ContrastTheme which allows different high contrast themes for visual accessibility Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Issac Bocage <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
Added 7 new high contrast themes Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Issac Bocage <[email protected]> Co-authored-by: Solomon Moon <[email protected]> Co-authored-by: Julianb12 <[email protected]>
…onent wrapper Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Isaac Bocage <[email protected]>
…mponent Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Isaac Bocage <[email protected]>
… working, and updated some dependencies. Fixed resizer tests and commented on some tests.Co-authored-by: Julian Bos <[email protected]>Co-authored-by: Mayson Lee <[email protected]>Co-authored-by: Isaac Bocage <[email protected]>
Solomon feature branch
Develop traverse function to unravel nodes object and return array of nodes Add save button to theme toggle component Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
2/6/24 Add Save Button and Develop Traverse Function
Co-authored-by: Julianb12 <[email protected]>
Mayson / High-Contrast Theme Component
Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Mayson Lee <[email protected]> Co-authored-by: Isaac Bocage <[email protected]>
the documentation Co-authored-by: Julian Bos <[email protected]> Co-authored-by: Isaac Bocage <[email protected]> Co-authored-by: Solomon Moon <[email protected]>
Contrast Theme Documentation
…lian Bos <[email protected]>Co-authored-by: Mayson Lee <[email protected]>Co-authored-by: Isaac Bocage <[email protected]>
…lian Bos <[email protected]>Co-authored-by: Mayson Lee <[email protected]>Co-authored-by: Isaac Bocage <[email protected]>
Solomon/readme
Pull Request for Main from Dev
…le.Co-authored-by: Julian Bos <[email protected]>Co-authored-by: Mayson Lee <[email protected]>Co-authored-by: Isaac Bocage <[email protected]>
…and themetoggle.Co-authored-by: Julian Bos <[email protected]>Co-authored-by: Mayson Lee <[email protected]>Co-authored-by: Isaac Bocage <[email protected]>
chobo91
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds new features implemented by the team for v10.0.
Features:
- Accessibility Enhancement: Now users can navigate the canvas using the keyboard.
- Persistent Canvas State: Added the ability to save the state persistently to local storage.
- High Contrast Mode: Introduced a new high contrast accessibility component tailored for the visually impaired.
Refactoring:
- Improved Keyboard Accessibility: Enhanced the keyboard accessibility of the drawer component through refactoring.
Miscellaneous:
- Test Enhancements: Added comprehensive testing for drawer components.
- Maintenance: Updated Playwright tests and configuration for improved stability.
Testing Instructions
Run
npm installto install all dependenciesRun
npx playwright installto install playwright and run testsRun
npm run devto open the dev environment and observe new features implemented in the canvasChecklist
N/A
Additional Notes, Images, etc.
N/A
Co-authored-by: Mayson Lee <[email protected]>
Co-authored-by: Isaac Bocage <[email protected]>
Co-authored-by: Julian Bos <[email protected]>
Co-authored-by: Solomon Moon <[email protected]>