Deal gracefully with missing hook.init #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that in some cases, VariableDeclaration elements in the AST are missing the init property. So add a check to handle this gracefully.
Author
|
I think I tracked down the origin of this to this declaration:
which is transpiled code from https://github.com/ant-design/ant-design/blob/678cf4948beec6fb2fadec7f930035c78ade51e2/components/steps/index.tsx#L46 |
Author
|
IOW, any uninitialised variable declaration would cause it. The reactime code seems to assume that the variable declaration must be a hook, but clearly that doesn't have to be the case. |
llam722
requested review from
SamuelTr13,
eminthrv,
llam722 and
yangbrian310
llam722
approved these changes
Nov 26, 2022
Contributor
llam722
left a comment
llam722
left a comment
There was a problem hiding this comment.
Hi aspiers,
Great catch regarding the uninitialised variable declaration and implementation of the optional chaining. Thanks for the contribution on this issue!
SamuelTr13
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in some cases, declarations inside
VariableDeclarationelements in the AST are missing the init property, e.g.:So add a check to handle this gracefully.