topdown/tokens_test: adjust expected signature for go1.18.1 #4580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanfylling
previously approved these changes
Apr 13, 2022
topdown/tokens_test.go
Outdated
| encodedSigned = "eyJhbGciOiAiRVMyNTYifQ.eyJwYXkiOiAibG9hZCJ9.-LoHxtbT8t_TnqlLyONI4BtjvfkySO8TcoCFENqTTH2AKxvn29nAjxOdlbY-0EKVM2nJ4ukCx4IGtZtuwXr0VQ" | ||
| case "go1.18.1": |
There was a problem hiding this comment.
Oh wait what did I do? This is probably wrong. I'll fix it.
There was a problem hiding this comment.
Ah now I see what happened. The signature didn't change, but the runtime.Version string did 🤦
Go 1.18.1 was released last night -- and while it doesn't change the signatures, it changes what `runtime.Version()` returns. Our test expectation didn't account for that. We've been pulling in go1.18.1 because our .go-version has 1.18 in it, and the docker image ref built from that for the `ci-go-*` make targets will use golang:1.18, which refers to the latest patch release. Signed-off-by: Stephan Renatus <[email protected]>
rokkiter
pushed a commit
to rokkiter/opa
that referenced
this pull request
Apr 18, 2022
…icy-agent#4580) Go 1.18.1 was released last night -- and while it doesn't change the signatures, it changes what `runtime.Version()` returns. Our test expectation didn't account for that. We've been pulling in go1.18.1 because our .go-version has 1.18 in it, and the docker image ref built from that for the `ci-go-*` make targets will use golang:1.18, which refers to the latest patch release. Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.18.1 was released last night -- and while it doesn't change
the signatures, it changes what
runtime.Version()returns.Our test expectation didn't account for that.
We've been pulling in go1.18.1 because our .go-version has 1.18 in it,
and the docker image ref built from that for the
ci-go-*make targetswill use golang:1.18, which refers to the latest patch release.