Skip to content

remove always inline attribute from hton/ntoh #9993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

hppritcha
Copy link
Member

for ob1 headers when configuring for hetero support.

Signed-off-by: Howard Pritchard [email protected]

for ob1 headers when configuring for hetero support.

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha requested a review from jsquyres February 8, 2022 18:40
@hppritcha
Copy link
Member Author

@jsquyres give this a try

@hppritcha
Copy link
Member Author

related to #9972

@jsquyres
Copy link
Member

jsquyres commented Feb 8, 2022

Yes, removing that "always inline" fixes the compile issue.

Is that a problem, performance-wise, though?

FYI @bwbarrett and @bosilca, who tend to care about changes in OB1.

@bosilca
Copy link
Member

bosilca commented Feb 8, 2022

I don't think we should have marked this function as always_inline, because according to the documentation this attribute is for functions that would not work properly if not inlined. We should still ask for the function to be inlined if possible, but let the compiler make the decision.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read @bosilca's comment as 👍

@awlauria
Copy link
Contributor

Refs: #9097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants