Update OpenPMIx and PRRTE submodules #9872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMIx Changes: 6ee928e Add libtool tweak for Cygwin 5d4fa87 Remove stale configure check d0b23d9 Add GIL protections to IOF callbacks, drop GIL when registering callbacks, fix allocation error in bytes object d0609f1 build: Fix escaping issue in pkg-config file Prrte Changes: 58650f8ed4 Protect against stone age HWLOC versions 3eb0e8f8f0 Update the lsf configure for better error output c8852c419b Tweak a variable name to avoid conflict f3402455fa Add missing m4's to tarball 155364c049 Fix issues impact cygwin bb80d5c4b1 Few minor configure cleanups 9ed0e0239e Silence Coverity warnings Signed-off-by: Brian Barrett <[email protected]>
rhc54
approved these changes
Jan 13, 2022
jsquyres
approved these changes
Jan 14, 2022
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
LGTM.
Before:
$ mpifort --showme
nagfor -I/home/jsquyres/bogus/include -I/home/jsquyres/bogus/lib -L/home/jsquyres/bogus/lib -L/home/jsquyres/bogus/lib -Wl,-rpath -Wl,@\{libdir\} -Wl,-Wl,,-rpath -Wl,-Wl,,/home/jsquyres/bogus/lib -Wl,-Wl,,-rpath -Wl,-Wl,,/home/jsquyres/bogus/lib -Wl,-Wl,,--enable-new-dtags -lmpi_usempif08 -lmpi_usempi_ignore_tkr -lmpi_mpifh -lmpi
After:
$ mpifort --showme
nagfor -I/home/jsquyres/bogus/include -I/home/jsquyres/bogus/lib -L/home/jsquyres/bogus/lib -L/home/jsquyres/bogus/lib -Wl,-rpath -Wl,/home/jsquyres/bogus/lib -Wl,-Wl,,-rpath -Wl,-Wl,,/home/jsquyres/bogus/lib -Wl,-Wl,,-rpath -Wl,-Wl,,/home/jsquyres/bogus/lib -Wl,-Wl,,--enable-new-dtags -lmpi_usempi -lmpi_mpifh -lmpi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMIx Changes:
6ee928e Add libtool tweak for Cygwin
5d4fa87 Remove stale configure check
d0b23d9 Add GIL protections to IOF callbacks, drop GIL when registering callbacks, fix allocation error in bytes object
d0609f1 build: Fix escaping issue in pkg-config file
Prrte Changes:
58650f8ed4 Protect against stone age HWLOC versions
3eb0e8f8f0 Update the lsf configure for better error output
c8852c419b Tweak a variable name to avoid conflict
f3402455fa Add missing m4's to tarball
155364c049 Fix issues impact cygwin
bb80d5c4b1 Few minor configure cleanups
9ed0e0239e Silence Coverity warnings
Signed-off-by: Brian Barrett [email protected]