Skip to content

Conversation

@tkordenbrock
Copy link
Member

@tkordenbrock tkordenbrock commented Oct 19, 2021

btl-portals4:
- move recv init inside the interface init loop
- fix uninitialized variable compiler warnings
- fix unused variable compiler warnings
- fix undefined variable failures in debug builds
mtl-portals4:
- move verbose output to the end of open() to avoid complicated message generation
- there is no function to add-fetch uint32_t, so change event_count type to opal_atomic_int32_t
coll-portals4:
- move declaration of loop index variables into the loop
- fix hidden loop index compiler warnings
- use REQUEST_COMPLETE to mark ompi_request_t complete
- remove incorrect req_complete initialization
osc-portals4:
- replace nonstatndard FUNCTION references with FILE
- use REQUEST_COMPLETE to mark ompi_request_t complete
- remove incorrect req_complete initialization
- add atomic compatible bytes_committed member to ompi_osc_portals4_request_t
- the request status _ucount member shouldn't be incremented directly with opal_atomic_add_fetch_32();
instead increment bytes_committed and assigned the result to _ucount
- remove initialization of nonexistent module members - osc_set_info and osc_get_info

Backport of commit 2fc4020

Signed-off-by: Todd Kordenbrock [email protected]
(cherry picked from commit 2fc4020)

@tkordenbrock
Copy link
Member Author

@jsquyres I didn't add a cherry pick line to this commit because it didn't apply cleanly. Instead I added a backport line. Should I edit the commit message to include a cherry pick line?

@jsquyres
Copy link
Member

Even if it's mostly a cherry pick, it would be good to add the line -- this tells us where the commit originally came from, at least.

    - move recv init inside the interface init loop
    - fix uninitialized variable compiler warnings
    - fix unused variable compiler warnings
    - fix undefined variable failures in debug builds
mtl-portals4:
    - move verbose output to the end of open() to avoid complicated message generation
    - there is no function to add-fetch uint32_t, so change event_count type to opal_atomic_int32_t
coll-portals4:
    - move declaration of loop index variables into the loop
    - fix hidden loop index compiler warnings
    - use REQUEST_COMPLETE to mark ompi_request_t complete
    - remove incorrect req_complete initialization
osc-portals4:
    - replace nonstatndard __FUNCTION__ references with __FILE__
    - use REQUEST_COMPLETE to mark ompi_request_t complete
    - remove incorrect req_complete initialization
    - add atomic compatible bytes_committed member to ompi_osc_portals4_request_t
    - the request status _ucount member shouldn't be incremented directly with opal_atomic_add_fetch_32();
      instead increment bytes_committed and assigned the result to _ucount
    - remove initialization of nonexistent module members - osc_set_info and osc_get_info

Signed-off-by: Todd Kordenbrock <[email protected]>
(cherry picked from commit 2fc4020)
@tkordenbrock tkordenbrock force-pushed the portals4/backports/v4.0.x/fix-compiler-warnings branch from 0157caf to 3336566 Compare October 19, 2021 20:23
@hppritcha
Copy link
Member

@mdosanjh if you want this in to 4.0.7 you need to review asap

Copy link
Contributor

@mdosanjh mdosanjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backports a number of fixes for the poratals4 components.

@hppritcha hppritcha merged commit ea88d98 into open-mpi:v4.0.x Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants