master: portals4: eliminate header order dependencies in the Portals4 components #9007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkordenbrock
changed the title
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/9d7e7d9001df8fbc5f5295b579396f56 |
|
The IBM CI (GNU/Scale) build failed! Please review the log, linked below. Gist: https://gist.github.com/bce8402ec8d3979f193efe051e5367ff |
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/874f054be6140905f5ab71241c0449a3 |
Signed-off-by: Todd Kordenbrock <[email protected]>
tkordenbrock
force-pushed
the
portals4/master/remove-include-ordering-dependency
branch
from
9f54a12 to
bf7906c
Compare
mdosanjh
approved these changes
Jun 8, 2021
tkordenbrock
deleted the
portals4/master/remove-include-ordering-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running clang-format in #8647, the portals4.h header was moved after the Portals4 component includes which caused compilation failures. This PR reorder headers to match the style of #8647 and adds includes where necessary to remove ordering dependencies.
This PR is blocked by #9006.