Skip to content

fix misleading error message with missing #! interpreter #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquyres merged 1 commit into from
Nov 27, 2019
Merged

fix misleading error message with missing #! interpreter #7153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions orte/mca/odls/default/odls_default_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,11 +454,22 @@ static int do_child(orte_odls_spawn_caddy_t *cd, int write_fd)

/* Exec the new executable */
execve(cd->cmd, cd->argv, cd->env);
getcwd(dir, sizeof(dir));
/* If we get here, an error has occurred. */
(void) getcwd(dir, sizeof(dir));
struct stat stats;
char* msg;
/* If errno is ENOENT, that indicates either cd->cmd does not exist, or
* cd->cmd is a script, but has a bad interpreter specified. */
if (ENOENT == errno && 0 == stat(cd->app->app, &stats)) {
asprintf(&msg, "%s has a bad interpreter on the first line.",
cd->app->app);
} else {
msg = strdup(strerror(errno));
}
send_error_show_help(write_fd, 1,
"help-orte-odls-default.txt", "execve error",
orte_process_info.nodename, dir, cd->app->app, strerror(errno));
/* Does not return */
orte_process_info.nodename, dir, cd->app->app, msg);
free(msg);
}


Expand Down