Update slurm pmi configury to account for pmix #6418
Merged
+219
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Slurm is built against PMIx, some installations place a copy of the PMIx library that Slurm is linking against in the Slurm PMI location. Current configury ignores that location. The desired behavior is to look for a PMIx lib in that location when --with-pmi is given. If the user also specifies --with-pmix and gives a different location, then override anything previously found and look for it where the user directed. Signed-off-by: Ralph Castain <[email protected]>
|
Refs spack/spack#10492 |
Signed-off-by: Ralph Castain <[email protected]>
|
@jsquyres This appears to be working as desired - you care to give it a once-over? |
|
So is this a fix for errors of the type: checking if user requested PMI support... yes
checking for pmi.h in /usr/include/slurm... found
checking pmi.h usability... yes
checking pmi.h presence... yes
checking for pmi.h... yes
checking for libpmi in /usr... not found
checking for pmi2.h in /usr/include/slurm... not found
checking for pmi2.h in /usr/include/slurm/include... not found
checking for pmi2.h in /usr/include/slurm/include/slurm... not found
checking for libpmi2 in /usr... not found
checking can PMI support be built... no
configure: WARNING: PMI support requested (via --with-pmi) but neither pmi.h
configure: WARNING: nor pmi2.h were found under locations:
configure: WARNING: /usr/include/slurm
configure: WARNING: /usr/include/slurm/slurm
configure: WARNING: Specified path: /usr/include/slurm
configure: WARNING: OR neither libpmi nor libpmi2 were found under:
configure: WARNING: /usr/lib
configure: WARNING: /usr/lib64
configure: WARNING: Specified path: /usr
configure: error: Aborting As discussed in #4338 ? |
|
Not sure - give it a try and see 😄 |
jsquyres
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Slurm is built against PMIx, some installations place a copy of the
PMIx library that Slurm is linking against in the Slurm PMI location.
Current configury ignores that location. The desired behavior is to look
for a PMIx lib in that location when --with-pmi is given. If the user
also specifies --with-pmix and gives a different location, then override
anything previously found and look for it where the user directed.
Signed-off-by: Ralph Castain [email protected]