Skip to content

Conversation

@uberlinuxguy
Copy link
Contributor

Signed-off-by: Jason Williams [email protected]

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@jsquyres
Copy link
Member

Refs #6303

ok to test

@jsquyres jsquyres added this to the v4.0.1 milestone Jan 28, 2019
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@ggouaillardet
Copy link
Contributor

@uberlinuxguy Thanks for the fix and the PR !

Since 98d81a5 has been merged into master, the way we do things in Open MPI is cherry-pick -x 98d81a5f7a619d5a19615297a6fe8a18d8e3781c into the release branches, so the commit message contains the following line

(cherry picked from commit 98d81a5f7a619d5a19615297a6fe8a18d8e3781c)

you might have to manually fix a few things because the cherry-pick does not work out of the box,
in this case I replace cherry picked with back-ported. In some cases, there is no cherry-pick possible because master does things differently than the release branches, and we explicitly state in the commit message this is a one-off commit for the release branches.

Could you please fix the PRs so they include the reference to the commit in the master branch ?
Then you will have to git push --force ... in order to overwrite the (commits of the) existing PRs.

@uberlinuxguy
Copy link
Contributor Author

Thank you for the clarification @ggouaillardet. I will go through them tomorrow and adjust them. I am sorry but I am new to the process. I read the docs, but I guess I missed some things or perhaps there are gaps. Not to worry, I got it now though. I did do a cherry pick, but I guess something got messed up in the commit. Where is the best place to ask if I have questions while trying to do the cherry picking?

@ggouaillardet
Copy link
Contributor

you can ask right here !

Signed-off-by: Jason Williams <[email protected]>

(cherry picked from commit 98d81a5)
@uberlinuxguy
Copy link
Contributor Author

@ggouaillardet I think I got the commit message updated now. I'll double check the other pull requests too, but does it look right to you now?

@ggouaillardet
Copy link
Contributor

This one looks good to me, thanks !

@hppritcha hppritcha merged commit d843220 into open-mpi:v4.0.x Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants