-
Notifications
You must be signed in to change notification settings - Fork 937
Adding changes for issue #6303 for branch v4.0.x. #6307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
Refs #6303 ok to test |
rhc54
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
|
@uberlinuxguy Thanks for the fix and the PR ! Since 98d81a5 has been merged into master, the way we do things in Open MPI is you might have to manually fix a few things because the cherry-pick does not work out of the box, Could you please fix the PRs so they include the reference to the commit in the |
|
Thank you for the clarification @ggouaillardet. I will go through them tomorrow and adjust them. I am sorry but I am new to the process. I read the docs, but I guess I missed some things or perhaps there are gaps. Not to worry, I got it now though. I did do a cherry pick, but I guess something got messed up in the commit. Where is the best place to ask if I have questions while trying to do the cherry picking? |
|
you can ask right here ! |
Signed-off-by: Jason Williams <[email protected]> (cherry picked from commit 98d81a5)
|
@ggouaillardet I think I got the commit message updated now. I'll double check the other pull requests too, but does it look right to you now? |
|
This one looks good to me, thanks ! |
Signed-off-by: Jason Williams [email protected]