Skip to content

common/ompio: possible rounding issue #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edgargabriel merged 1 commit into from
Jan 19, 2019
Merged

common/ompio: possible rounding issue #6287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ompi/mca/common/ompio/common_ompio_aggregators.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,11 +896,14 @@ int mca_common_ompio_split_initial_groups(ompio_file_t *fh,
int size_smallest_group = 0;
int num_groups = 0;
int ret = OMPI_SUCCESS;
OMPI_MPI_COUNT_TYPE bytes_per_agg_group = 0;
Copy link
Contributor Author

@psychocoderHPC psychocoderHPC Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is OMPI_MPI_COUNT_TYPE the right type for a byte count here or should it be MPI_Aint?


OMPI_MPI_OFFSET_TYPE max_cci = 0;
OMPI_MPI_OFFSET_TYPE min_cci = 0;

size_new_group = ceil ((float)OMPIO_MCA_GET(fh, bytes_per_agg) * fh->f_init_procs_per_group/ bytes_per_group);
bytes_per_agg_group = (OMPI_MPI_COUNT_TYPE)OMPIO_MCA_GET(fh, bytes_per_agg);
// integer round up
size_new_group = (int)(bytes_per_agg_group / bytes_per_group + (bytes_per_agg_group % bytes_per_group ? 1u : 0u));
size_old_group = fh->f_init_procs_per_group;

ret = mca_common_ompio_split_a_group(fh,
Expand Down Expand Up @@ -948,7 +951,7 @@ int mca_common_ompio_split_initial_groups(ompio_file_t *fh,
if((max_cci < OMPIO_CONTG_THRESHOLD) &&
(size_new_group < size_old_group)){

size_new_group = floor( (float) (size_new_group + size_old_group ) / 2 );
size_new_group = (size_new_group + size_old_group ) / 2;
ret = mca_common_ompio_split_a_group(fh,
start_offsets_lens,
end_offsets,
Expand Down Expand Up @@ -976,7 +979,9 @@ int mca_common_ompio_split_initial_groups(ompio_file_t *fh,
(size_new_group < size_old_group)){ //can be a better condition
//monitor the previous iteration
//break if it has not changed.
size_new_group = ceil( (float) (size_new_group + size_old_group ) / 2 );
size_new_group = size_new_group + size_old_group;
// integer round up
size_new_group = size_new_group / 2 + (size_new_group % 2 ? 1 : 0);
ret = mca_common_ompio_split_a_group(fh,
start_offsets_lens,
end_offsets,
Expand Down