oshmem/scoll: fix shmem_collect32/64 for zero-size length #6234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hoopoepg pls take a look |
Fixes scoll_basic failures with shmem_verifier, caused by recent changes in handling of zero-size collectives. - Check for zero-size length only for fixed size collect (shmem_fcollect), but not for variable-size collect (shmem_collect) - Add 'nlong_type' parameter to internal broadcast function, to indicate whether the 'nlong' parameter is valid on non-root PEs, since it's used by shmem_collect algorithm. Before this change, some components assumed it's true (scoll_mpi) while others assumed it's false (scoll_basic). - In scoll_basic, if nlong_type==false, do not exit if nlong==0, since this parameter may not be the same on all PEs. - In scoll_mpi, fallback to scoll_basic if nlong_type==false, since MPI requires the 'count' argument of MPI_Bcast to be valid on all ranks. Signed-off-by: Yossi Itigin <[email protected]>
yosefe
force-pushed
the
topic/scoll-basic-fix-zero-size-collect
branch
from
628fd3b to
939162e
Compare
hoopoepg
approved these changes
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openucx/ucx#3063 (comment)