shmem/lock: progress communications while waiting for shmem_lock #5717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yossi Itigin <[email protected]>
hoopoepg
approved these changes
Sep 16, 2018
|
In the future, for PRs like this, it would be nice to have a link to an issue with more details such as:
The reason this is important for PRs like this, is because additional calls to opal_progress can have wide reaching performance issues, and if any performance regression is traced back to this PR, we'd need to understand if this a bit better. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the underlying SPML requires active progress on target side (e.g RMA emulation over active messages), need to call opal_progress() to avoid a deadlock.
For example, when UCX is using TCP transport.