Remove few warnings identified by @rhc in #5514. #5517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Aug 3, 2018
| arch = (double**)MALLOC(sizeof(double*)*nb_proc); | ||
| if( NULL == arch ) |
There was a problem hiding this comment.
Minor: both of these blocks don't obey our code standards of always including blocks -- even 1-line blocks -- in {}. 😜
There was a problem hiding this comment.
Based on the code accepted lately I was under the impression that we are not following the code standard anymore...
There was a problem hiding this comment.
That and 4-space tabs are about the only thing we ever enforced from the code standards (minimal that they were)... Maybe putting { in the same line as if/while/etc., too.
Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
topic/treematch_warnings
branch
from
927d0a2 to
6d11a45
Compare
hjelmn
approved these changes
Aug 6, 2018
jsquyres
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: George Bosilca [email protected]
Refs #5514 #5512