PML/UCX: fixed ucp request free on persistent request completion #5461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in sine cases persistent request was deleted during completion callback, this cause double free of linked UCX request (assert in debug build or hang in release build) - UCX request is freed prior completion calback Signed-off-by: Sergey Oblomov <[email protected]>
Contributor
Author
|
@yosefe could you look? |
Contributor
|
does this replace the fix for osc_pt2pt? |
yosefe
approved these changes
Jul 20, 2018
Contributor
Author
|
are you about this PR #5460 ? |
Contributor
|
nice. does osc_pt2pt work with ucx with this fix? |
Contributor
Author
|
yes, It passes all mpi_test_suite tests with this fix. |
Contributor
|
wow, very nice! can you pls pick it to v4.0 and v3.1 (no need for older ones) |
Contributor
Author
|
ok, will do after this PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callback, this cause double free of linked UCX request (assert
in debug build or hang in release build)
Signed-off-by: Sergey Oblomov [email protected]