cuda: add option to remove warning about missing libcuda. #5188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
approved these changes
May 23, 2018
jsquyres
requested changes
May 23, 2018
opal/mca/common/cuda/common_cuda.c
Outdated
| opal_show_help("help-mpi-common-cuda.txt", "dlopen failed", true, | ||
| errmsg); | ||
| if (opal_warn_on_missing_libcuda) { | ||
| opal_show_help("help-mpi-common-cuda.txt", "dlopen failed", true, |
Member
There was a problem hiding this comment.
Super minor nit: should be a 4-space tab, not a 2-space tab.
Signed-off-by: Sylvain Jeaugey <[email protected]>
Member
Author
|
@jsquyres spaces fixed and commits squashed. |
jsquyres
approved these changes
May 24, 2018
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Thanks!
Merge when CI completes.
Member
|
bot:ompi:retest |
Member
|
@sjeaugey You might want to see if the RM's are amenable to you cherry picking this PR to the release branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4405