Skip to content

oshmem: remove shmem_put/get when not the C11 case in accordance with the spec v1.3 #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2018
Merged

oshmem: remove shmem_put/get when not the C11 case in accordance with the spec v1.3 #4638

merged 1 commit into from
May 27, 2018

Conversation

karasevb
Copy link
Member

Fixes: #4307

Signed-off-by: Boris Karasev [email protected]

@artpol84
Copy link
Contributor

artpol84 commented Dec 19, 2017 •
edited
Loading

@Di0gen @miked-mellanox @jladd-mlnx

13:25:19 [htmlpublisher] Archiving HTML reports...
13:25:19 [htmlpublisher] Archiving at BUILD level /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/cov_build to /var/lib/jenkins/jobs/gh-ompi-master-pr/builds/6960/htmlreports/Coverity_Report
13:25:19 ERROR: Build step failed with exception
13:25:19 java.io.IOException: No space left on device

And the same issue was observed at #4606 (comment)

@artpol84
Copy link
Contributor

No space issue should be fixed

@artpol84
Copy link
Contributor

bot:mellanox:retest

@artpol84
Copy link
Contributor

@jladd-mlnx @miked-mellanox can you have a look?

@artpol84
Copy link
Contributor

artpol84 commented Dec 19, 2017 •
edited
Loading

@BryantLam, can you verify that this is what was requested?

@BryantLam
Copy link

@artpol84, Looks good to me. Thanks!

artpol84
artpol84 approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@artpol84 artpol84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsquyres jsquyres added the bug label Jan 3, 2018
@jsquyres
Copy link
Member

jsquyres commented Jan 3, 2018

Note: This PR will affect OSHMEM ABI.

@jsquyres jsquyres mentioned this pull request Jan 3, 2018
Closed
@artpol84 artpol84 mentioned this pull request Feb 5, 2018
Closed
@jsquyres
Copy link
Member

@artpol84 @karasevb Is this aimed for v4.0.0? If so, it should be merged.

@artpol84 artpol84 merged commit 66e774d into open-mpi:master May 27, 2018
@artpol84
Copy link
Contributor

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artpol84 artpol84 artpol84 approved these changes

@jladd-mlnx jladd-mlnx Awaiting requested review from jladd-mlnx

Assignees
No one assigned
Labels
bug Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karasevb @artpol84 @BryantLam @jsquyres @bwbarrett