Naming conflict for shmem_put/get in shmem-compat.h #4307
Assignees
Comments
|
@karasevb please address |
karasevb
added a commit
to karasevb/ompi
that referenced
this issue
Dec 19, 2017
…th the spec v1.3 Fixes: open-mpi#4307 Signed-off-by: Boris Karasev <[email protected]>
|
Fixed by #4638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
shmem-compat.h is included after a compiler check for C11 support. OpenSHMEM 1.3 added type-generic
shmem_putandshmem_getthat are defined as macros later inshmem.h.inand subsequently conflict with the function declarations inshmem-compat.h.One solution is to add a check in
shmem-compat.hthat checks forOSHMEM_HAVE_C11to prefer the C11 generics, but this provides an invisible breaking change to existing codes that erroneously depend onshmem-compat.h'sshmem_put. It would be better to get rid of the function declarations inshmem-compat.hnow that it sufficiently conflicts with the OpenSHMEM specification.The text was updated successfully, but these errors were encountered: