Remove visibility directives from public APIs #4071
Conversation
|
ah come on, jenkins - stop the infrastructure failures bot:ompi:retest |
|
i wonder if it is possible for the OMPI jenkins to run all these variations without suffering an infrastructure failure? bot:ompi:retest |
|
hold on here - we have a revised method that is a better long-term fix |
|
Refs openpmix/openpmix#451 |
Signed-off-by: Ralph Castain <[email protected]>
|
@jjhursey should be okay now |
There was a problem hiding this comment.
This commit updates the OMPI v2.x branch to the latest HEAD of PMIx v1.2 to:
- Include openpmix/openpmix#451 (visibility)
- But excludes PR openpmix/openpmix#458 (rm generated atomics)
Was excluding the atomics PR intentional here so PMIx ASM level matches that of OMPI? Or should we refresh this PR to include that removal in PMIx?
|
It was just timing. However, I'm thinking that PMIx v1.2.3 should be ready to go now, if you have time and are willing to generate the rc. Might be good if we can provide OMPI with an official release. |
|
@rhc54 Yeah I think we should. With these recent changes we should probably setup an RC. That'll also make it easier for the packaging folks to test out the visibility changes. I'll put it on the list for today. |
|
Ref PMIx v1.2.3rc1 |
|
Per Webex discussion on 15 Aug, we'll take this PR and then be ok to make another RC. We might take another follow on PR that just updates the VERSION file in PMIx to be 1.2.3, just to be a little more expressive in the PMIx version file. |
Fixes #4069
Signed-off-by: Ralph Castain [email protected]