Fix linking of libpmix when emitted #4046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jsquyres I'm not sure this fix is correct - at least, it is breaking --disable-dlopen builds on master. I'm working on a variant of it for there. |
added 2 commits
August 15, 2017 14:57
… However, that library was built against the OPAL libevent component, which means all the libevent functions are prefixed with OPAL names. So ensure that the emitted libpmix is linked back against libopen-pal so those symbols will be resolved. Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit d593e5a)
…mix link back to libopen-pal as the latter won't exist in time during this build case Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 033a0eb) (cherry picked from commit 1af5e8a)
Contributor
Author
|
@jsquyres I think I have this correct now - please let me know what you think |
jsquyres
reviewed
Aug 16, 2017
opal/mca/pmix/pmix2x/configure.m4
Outdated
| CFLAGS="$OPAL_CFLAGS_BEFORE_PICKY $OPAL_VISIBILITY_CFLAGS"]) | ||
| AS_IF([test "$with_devel_headers" = "yes"], | ||
| [opal_pmix_pmix2x_args="--with-devel-headers --with-pmix-extra-lib=$OPAL_TOP_BUILDDIR/opal/lib${OPAL_LIB_PREFIX}open-pal.la $opal_pmix_pmix2x_args"]) | ||
| [AS_IF([test "$enable_dlopen" = "yes"], |
Member
There was a problem hiding this comment.
Should this be "$enable_dlopen" != "no" to cover the case when $enable_dlopen is blank?
Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit c4d5dbf)
Contributor
Author
|
@jsquyres Done, as requested |
jsquyres
approved these changes
Aug 16, 2017
Contributor
Author
|
cray test node failed to respond bot:ompi:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we specify --with-devel-headers, we also emit a copy of libpmix. However, that library was built against the OPAL libevent component, which means all the libevent functions are prefixed with OPAL names. So ensure that the emitted libpmix is linked back against libopen-pal so those symbols will be resolved.
Fixes #4045
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit d593e5a)