Fixes the pmix1x external component #3677
Conversation
- fixed the `jobid` tracker, was not added item before using it - the server side of PMIx v1 component didn't register own nspace, that didn't allow the use of the PMIx functions Signed-off-by: Boris Karasev <[email protected]>
|
@karasevb This looks fine, but it needs to go into master first. Thanks for debugging it! |
|
@rhc54 @artpol84 |
|
My point was that these changes are not present in master, and need to be there prior to bringing them to a release branch. I've submitted #3687 to do so. Once that is committed and "soaks" over the weekend, I'll approve this PR. |
|
@karasevb 's point is that differences in master and v3.x are sufficient. If I understood him correctly it seems that unless static ports are used this piece of code will not be executed. However in v3.x this is not a case. In v3.0.x: In v3.x Why Master and v3.0.x rely on static ports being used and v3.x doesn't? This is the thing that we need to converge before going further. |
|
"Once that is committed and "soaks" over the weekend, I'll approve this PR." |
Signed-off-by: Ralph Castain <[email protected]>
Fixes the pmix1x external component
jobidtracker, was not added item before using itnspace, that didn't allow the use of the PMIx functions
Fixed #3200
Signed-off-by: Boris Karasev [email protected]