sharedfp/lockedfile and sm: fix the namecollision #3103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
pr/sharedfp-name-collision-fix
branch
from
36fd37b to
cf08409
Compare
rhc54
requested changes
Mar 5, 2017
| if ( 0 == comm->c_my_rank ) { | ||
| ompi_proc_t *masterproc = ompi_group_peer_lookup(comm->c_local_group, 0 ); | ||
| opal_process_name_t *mastername = &(masterproc->super.proc_name); | ||
| masterjobid = mastername->jobid; |
There was a problem hiding this comment.
I believe the "correct" way to get the jobid involves using a macro:
OMPI_CAST_RTE_NAME(&proc->super.proc_name)->jobid = jobid;
Other than that, this should be fine.
this fixes the issue reported by Nicolas Joly on the mailing: the sharedfp/lockedfile component does not support right now a scenario where multiple jobs read from the same input file, due to a collision of the filenames utilized for the sharedfp handle. Although not part of the oroginal report, the same occurs for the sharedfp/sm component. Add therefore the jobid to be part of the lockedfilename/sm file name. use the OMPI_CAST_RTE_NAME macro to determine jobid Fixes: open-mpi#3098 Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
pr/sharedfp-name-collision-fix
branch
from
cf08409 to
2d462b3
Compare
|
Thanks Ralph, I incorporated your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the issue reported by Nicolas Joly on the mailing: the sharedfp/lockedfile component does not support right now a scenario where multiple jobs read from the same input file, due to a collision of the filenames utilized for the sharedfp handle. Although not part of the oroginal report, the same occurs for the sharedfp/sm component. Add therefore the jobid to be part of the lockedfilename/sm file name.
Fixes: #3098
Signed-off-by: Edgar Gabriel [email protected]